Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Multiline Signature Formatting #234

Closed
mbabker opened this issue Apr 13, 2018 · 4 comments
Closed

[RFC] Multiline Signature Formatting #234

mbabker opened this issue Apr 13, 2018 · 4 comments

Comments

@mbabker
Copy link
Contributor

mbabker commented Apr 13, 2018

Long and short, our existing rules for multiline signature formatting sucks, see joomla/joomla-cms@34555af as an example of something I had to "downgrade" to pass PHPCS.

This is not highly readable code. We can do better.

@rdeutz
Copy link
Contributor

rdeutz commented Apr 13, 2018

I agree.

@Septdir
Copy link

Septdir commented Apr 25, 2018

I use PhpStorm and in my (slightly modified stator Joomla) Code Style MultiLine looks like joomla/joomla-cms@cb41a47

However it was necessary so joomla/joomla-cms@a3406a2

And if you really use Multiline, the version that was the first to read much more conveniently

@photodude
Copy link
Contributor

Since that's on the CMS I'm assuming that's a failure in the 1.5.x version of the code style checks, and not the newer 2.0 or 3.0 versions.

@mbabker
Copy link
Contributor Author

mbabker commented Feb 9, 2019

Works fine, even with PHPCS 1.5 definition if you remember to put the closing parenthesis on the same line as the last argument

@mbabker mbabker closed this as completed Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants