Changed Linux build to use 16-bit wide chars, to fix issue #5132 #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Ehhhh.... if the issue is the VHD image code using wchar_t, forcing the whole project to use 16-bit wchar is kind of a sledgehammer approach that might cause other problems. Other libraries in Linux that use the normal wchar_t, for example. I think a better approach is to modify the VHD image code to change wchar_t to uint16_t so the strings line up properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a summary of the change(s) brought by this PR here.
What issue(s) does this PR address?
#5132
Does this PR introduce new feature(s)?
no
Does this PR introduce any breaking change(s)?
no
Additional information
VHD Differencing is broken on Linux systems, this fixes the issue, by using the same size chars as on Windows and Macs