Fix internal sdlnet build on macOS, enables nullmodem/modem support on macOS for SDL1 builds #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badlogic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix internal sdlnet build on macOS, which re-enables support for nullmodem and modem on macOS for SDL1 builds.
What issue(s) does this PR address?
See #3534, on macOS, SDL1 builds do not link in sdlnet, and thus modem support is disabled.
The problem was that the sdlnet build produces a
libSDL_net.afile that not only contains the object files, but alsolibSDL.aandlibSDLmain.a. This leads to issues down the line, when linking againstlibSDL_net.a, producing non-sensical linker error messages likebuilding for macOS-x86_64 but attempting to link with file built for macOS-x86_64.I have not found a way to prevent the addition of those files. The fix is thus simply deleting them from the
.afile right afterlibSDL_net.ahas finished building.Does this PR introduce new feature(s)?
No.
Does this PR introduce any breaking change(s)?
No.