Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add domain url option for private repos #21

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat: add domain url option for private repos #21

merged 2 commits into from
Oct 31, 2023

Conversation

jalexispoveda
Copy link
Contributor

@jalexispoveda jalexispoveda commented Oct 30, 2023 •
edited by jonaslagoni

@jonaslagoni I believe this helps to include private repos. Please take a look and let me know your thoughts.

Fixes #20

@jalexispoveda jalexispoveda changed the title Implemented domain URL for private repos implemented domain url for private repos Oct 30, 2023
@jalexispoveda jalexispoveda mentioned this pull request Oct 30, 2023
Closed
@jonaslagoni jonaslagoni changed the title implemented domain url for private repos feat: add domain url option for private repos Oct 31, 2023
jonaslagoni
jonaslagoni requested changes Oct 31, 2023
View reviewed changes
Copy link
Owner

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

You just have a few linting issues to fix 😃

@jalexispoveda
Copy link
Contributor Author

@jonaslagoni I believe it's all set!

jonaslagoni
jonaslagoni approved these changes Oct 31, 2023
View reviewed changes
Copy link
Owner

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for taking the time!

@jonaslagoni jonaslagoni merged commit b900eee into jonaslagoni:main Oct 31, 2023
4 of 5 checks passed
@jonaslagoni
Copy link
Owner

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jalexispoveda
Copy link
Contributor Author

Hi @jonaslagoni , thank you for approving this. How do I make sure I am using the latest version of this? This is what I have but I don't see the new code applied

        uses:  joneja09/gh-action-dotnet-bump@main
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          version-part: 'Patch'
          path-to-file: 'Mango.Web/Mango.Web.csproj'
          repository-domain: 'test'`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to configure this action in case the repo has a private URL?
2 participants
@jalexispoveda @jonaslagoni