* OLD * Migrated parameters #2017

caco3 · 2023-02-12T09:31:26Z

replaced by #2023

* Update interface_influxdb.cpp * Correct to UTC

* Update edit_config_param.html * Update ClassFlowAlignment.cpp

* Update defines.h * Update: Disable USE_HIMEM_IF_AVAILABLE

* Update config.ini * Update config.ini * Update config.ini

* Update build.yaml * Update build.yaml * Update build.yaml

* Implement InfluxDBv2 Innitial * Update incl. UI * Correct UI * Update UI - Indiv. Param. * Update edit_config_param.html * Correct Timeshift * Update Fieldname

Slider0007 · 2023-02-12T09:57:43Z

@caco3, @jomjol: Some more discussion points in terms of config parameters:

main.ExtendedResolution in section [ANALOG]
--> Couldn't find in software

TimeServer = pool.ntp.org
--> I would remove the checkbox, because disabled parameter does not mean that service is disabled. Actual logic only disables timeservice when input field is empty.

Hostname = watermeter
--> I would remove the checkbox and set the default value (watermeter; to be aligned with logic). Disabling the parameter does nothing with actual logic (internally, default name is used anyway).

RSSIThreashold = 0
--> I would remove the checkbox, because function gets disabled with input = 0 and in my opinion there is no benefit to disable parameter additionally. It's hidden in expert anyway.

##############################
Defaults of parameters:
CNNGoodThreshold --> I would disable this by default, because it's experimental and only used for some models.
InitialRotate = 179 -> Default: 0?

main.MaxRateValue = 0.05
;main.MaxRateType = AbsoluteChange
--> MaxRateValue is enabled by default and MaxRateType is disabled? Is this by purpose? (AbsolutChange is default internally)

Slider0007 · 2023-02-12T10:06:24Z

@caco3, @jomjol: Having an additional parameter adpation logic in firmware we have now two locations were parameters are adapted for migration/compability reason.
Just for my understanding: In future what will be handled in JS (readconfigparam.js) and what handled in directly firmware?

caco3 · 2023-02-12T10:11:51Z

What do you mean with "additional parameter adpation logic in firmware"? I only added function to migrate the parameters. and it works on the plain text file.
Beside of this, change of boolean parameters and all the renaming, nothing should have changed.

Slider0007 · 2023-02-12T10:18:45Z

What do you mean with "additional parameter adpation logic in firmware"? I only added function to migrate the parameters. and it works on the plain text file. Beside of this, change of boolean parameters and all the renaming, nothing should have changed.

I mean your migrate function. I was just thinking about this compabilty part in readconfigparam.js were parameters are also e.g. renamed and partly modified due to compability reason.

caco3 · 2023-02-12T10:45:01Z

What do you mean with "additional parameter adpation logic in firmware"? I only added function to migrate the parameters. and it works on the plain text file. Beside of this, change of boolean parameters and all the renaming, nothing should have changed.

I mean your migrate function. I was just thinking about this compabilty part in readconfigparam.js were parameters are also e.g. renamed and partly modified due to compability reason.

The whole migration happens in the migration function in the firmware.
The rest of the firmware and Web UI only adapt the changed names.
The Web UI does not rename anything!

Slider0007 · 2023-02-12T11:09:02Z

What do you mean with "additional parameter adpation logic in firmware"? I only added function to migrate the parameters. and it works on the plain text file. Beside of this, change of boolean parameters and all the renaming, nothing should have changed.

I mean your migrate function. I was just thinking about this compabilty part in readconfigparam.js were parameters are also e.g. renamed and partly modified due to compability reason.

The whole migration happens in the migration function in the firmware. The rest of the firmware and Web UI only adapt the changed names. The Web UI does not rename anything!

Here and in the following lines some parameters are "modified" due to compability reason:

AI-on-the-edge-device/sd-card/html/readconfigparam.js

Line 289 in 44e186e

// Make the downward compatiblity with MQTT (Maintopic --> topic)

Maybe @jomjol can tell more to this.

caco3 · 2023-02-12T17:23:50Z

To simplify the PR, I only do the renaming in this PR.
The change of paths and migration of commented out boolean to enabled params with default will be done separately.

caco3 · 2023-02-12T19:15:21Z

@Slider0007 Thanks for thinking into it!

main.ExtendedResolution in section [ANALOG] --> Couldn't find in software

Removed now (its only used in [PostProcessing])

TimeServer = pool.ntp.org --> I would remove the checkbox, because disabled parameter does not mean that service is disabled. Actual logic only disables timeservice when input field is empty.

Let's do that later to keep it as simple as possible.

Hostname = watermeter --> I would remove the checkbox and set the default value (watermeter; to be aligned with logic). Disabling the parameter does nothing with actual logic (internally, default name is used anyway).

Let's do that later to keep it as simple as possible. Also I would remove water from the default value.

RSSIThreashold = 0 --> I would remove the checkbox, because function gets disabled with input = 0 and in my opinion there is no benefit to disable parameter additionally. It's hidden in expert anyway.

Let's do that later to keep it as simple as possible.

Defaults of parameters: CNNGoodThreshold --> I would disable this by default, because it's experimental and only used for some models. InitialRotate = 179 -> Default: 0?

@jomjol What do you think? The default in the firmware seems to be 0.0!

main.MaxRateValue = 0.05 ;
main.MaxRateType = AbsoluteChange --> MaxRateValue is enabled by default and MaxRateType is disabled? Is this by purpose? (AbsolutChange is default internally)

@jomjol ?

caco3 · 2023-02-12T19:16:09Z

What do you mean with "additional parameter adpation logic in firmware"? I only added function to migrate the parameters. and it works on the plain text file. Beside of this, change of boolean parameters and all the renaming, nothing should have changed.

I mean your migrate function. I was just thinking about this compabilty part in readconfigparam.js were parameters are also e.g. renamed and partly modified due to compability reason.

The whole migration happens in the migration function in the firmware. The rest of the firmware and Web UI only adapt the changed names. The Web UI does not rename anything!

Here and in the following lines some parameters are "modified" due to compability reason:

AI-on-the-edge-device/sd-card/html/readconfigparam.js

Line 289 in 44e186e

// Make the downward compatiblity with MQTT (Maintopic --> topic)

Maybe @jomjol can tell more to this.

That is old code, not sure if we still need it but I would keep it as is for now to keep the PR as simple as possible.

caco3 · 2023-02-12T21:23:09Z

As far as I tested, it should be complete now.
But I had to create another PR for this as I accidentally included the InfluxDB2 stuff.
How ever I really only want to have the parameter migration contained.

Please review and test #2023

jomjol and others added 21 commits February 2, 2023 19:14

Correct influx utc (#1964)

69583db

* Update interface_influxdb.cpp * Correct to UTC

Option alignment algo off (#1924)

1d2f920

* Update edit_config_param.html * Update ClassFlowAlignment.cpp

Cleanup defines.h (#1967)

2ee8500

* Update defines.h * Update: Disable USE_HIMEM_IF_AVAILABLE

Update manual-update-webinstaller.yml

d63dc08

fix broken webinstaller update

4bfe542

Merge branch 'Increase-max-JPG-size' into rolling

34a3d6d

Update Changelog.md

800e231

wifi disconnect before deinit (#1978)

55efc3b

Cleanup config (#1972)

06f4d41

* Update config.ini * Update config.ini * Update config.ini

ota_page: Add missing quotation mark (#1977)

b9134f9

Use the preprocessed Web UI for the manual.zip (#1983)

3fa16c5

* Update build.yaml * Update build.yaml * Update build.yaml

Update manual-update-webinstaller.yml

30a5072

Update README.md

bf090f3

Fix small typo (#1995)

876adc5

Update interface_influxdb.cpp

a9c5beb

Update Changelog.md

0b2e389

Merge branch 'InfluxDB-Fix-Timeshift' into rolling

795bcd0

Implement InfluxDB v2 (#2004)

1acd72d

* Implement InfluxDBv2 Innitial * Update incl. UI * Correct UI * Update UI - Indiv. Param. * Update edit_config_param.html * Correct Timeshift * Update Fieldname

Update Changelog.md

55be652

Update backup.html (#2015)

44e186e

Migrated parameters

1e633bb

caco3 mentioned this pull request Feb 12, 2023

*** OLD *** Migrate configuration -> Superseeded by PR2017 #2001

Closed

3 tasks

Merge branch 'rolling' into migrate-parameters

764c462

.

a27bad4

re-implemented parameter migration

13e3ba1

renaming

cfc6ea2

CaCO3 added 10 commits February 12, 2023 20:21

.

d1e3751

.

7eb690a

.

10e84e6

.

6d111eb

.

ebcd858

.

21c835c

.

15ca4e0

.

60e7596

.

92bed76

.

da487f7

caco3 marked this pull request as ready for review February 12, 2023 20:29

.

31f6bfe

caco3 changed the base branch from rolling to v14.1 February 12, 2023 20:49

removed influxDB2, we do not want it yet in v14.1!

55523ac

caco3 marked this pull request as draft February 12, 2023 20:59

caco3 closed this Feb 12, 2023

caco3 mentioned this pull request Feb 12, 2023

Migrate parameters #2023

Merged

caco3 changed the title ~~Migrated parameters~~ *** OLD *** Migrated parameters Feb 12, 2023

caco3 deleted the migrate-parameters branch February 21, 2023 21:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

* OLD * Migrated parameters #2017

* OLD * Migrated parameters #2017

caco3 commented Feb 12, 2023 •

edited

Loading

Slider0007 commented Feb 12, 2023

Slider0007 commented Feb 12, 2023 •

edited

Loading

caco3 commented Feb 12, 2023

Slider0007 commented Feb 12, 2023

caco3 commented Feb 12, 2023

Slider0007 commented Feb 12, 2023

caco3 commented Feb 12, 2023

caco3 commented Feb 12, 2023

caco3 commented Feb 12, 2023

caco3 commented Feb 12, 2023

*** OLD *** Migrated parameters #2017

*** OLD *** Migrated parameters #2017

Conversation

caco3 commented Feb 12, 2023 • edited Loading

Slider0007 commented Feb 12, 2023

Slider0007 commented Feb 12, 2023 • edited Loading

caco3 commented Feb 12, 2023

Slider0007 commented Feb 12, 2023

caco3 commented Feb 12, 2023

Slider0007 commented Feb 12, 2023

caco3 commented Feb 12, 2023

caco3 commented Feb 12, 2023

caco3 commented Feb 12, 2023

caco3 commented Feb 12, 2023

* OLD * Migrated parameters #2017

* OLD * Migrated parameters #2017

caco3 commented Feb 12, 2023 •

edited

Loading

Slider0007 commented Feb 12, 2023 •

edited

Loading