Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable separator #372

Closed
1 task
johnwalley opened this issue Jul 27, 2022 · 4 comments · Fixed by #388
Closed
1 task

Disable separator #372

johnwalley opened this issue Jul 27, 2022 · 4 comments · Fixed by #388
Labels
enhancement New feature or request

Comments

@johnwalley
Copy link
Owner

Purpose

As a developer I want to disable the separator because I want to handle this myself.

Proposal

Probably a prop rather than css.

Acceptance criteria

  • As a developer I can disable the separator
@johnwalley johnwalley added the enhancement New feature or request label Jul 27, 2022
@johnwalley johnwalley self-assigned this Jul 27, 2022
@uwemneku
Copy link

uwemneku commented Aug 1, 2022

Hi @johnwalley, is this issue still available? If yes, I would love to work on it

@johnwalley johnwalley removed their assignment Aug 2, 2022
@johnwalley
Copy link
Owner Author

Hi @uwemneku. I've not started on this issue and would be happy for you to take it on 👍

@uwemneku
Copy link

uwemneku commented Aug 2, 2022

Thanks, @johnwalley. So I understand the task better, the props to disable the separator would make the separator-border invisible right? And would this also affect the blue hover effect for the sash?

@johnwalley
Copy link
Owner Author

I imagine a prop, say separator={boolean} on the main component.

If it is false then we don't add the before pseudo element. Just to be clear, we simply don't add it, rather than make it invisible.

@johnwalley johnwalley linked a pull request Aug 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants