GWHAT crash when trying to save the monthly weather average graph to disk.

[jnsebgosselin]

What steps will reproduce the problem?

1. Open GWHAT and go to the Plot Hydrograph tab.
2. Open the Weather Averages window
3. Try to save the graph

Traceback (most recent call last):
  File "C:\Users\jsgosselin\GWHAT\gwhat\meteo\weather_viewer.py", line 239, in s
ave_graph
    dialog.setConfirmOverwrite(True)
AttributeError: 'QFileDialog' object has no attribute 'setConfirmOverwrite'

[jnsebgosselin]

This bug is cause by a change that was introduced in the Qt API between qt4 and qt5. Since by default QFileDialog ask for confirmation before overriding, I think that all the setConfirmOverwrite can be removed from the code.

http://doc.qt.io/qt-5/qfiledialog-obsolete.html
https://doc.qt.io/qt-5/qfiledialog.html

[jnsebgosselin]

Fixing the above error, GWHAT is still crashing. The way getSaveFileName is called must also be changed to respect the qt5 API.

Traceback (most recent call last):
  File "C:\Users\jsgosselin\GWHAT\gwhat\meteo\weather_viewer.py", line 240, in s
ave_graph
    caption='Save graph', dir=ddir, filter='*.pdf;;*.svg')
TypeError: getSaveFileName(parent: QWidget = None, caption: str = '', directory:
 str = '', filter: str = '', initialFilter: str = '', options: Union[QFileDialog
.Options, QFileDialog.Option] = 0): 'dir' is not a valid keyword argument