Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report Block inside If Statement exits top level script #3252

Closed
gustav-langer opened this issue Sep 14, 2023 · 3 comments
Closed

Report Block inside If Statement exits top level script #3252

gustav-langer opened this issue Sep 14, 2023 · 3 comments
Assignees
Labels

Comments

@gustav-langer
Copy link

When a report block inside an if block is called, it will act almost like a [stop this script].
This works inside a custom command block and inside a ring executed by either call or run, but not in a custom reporter block.
this works image
image
image

image image

It also doesn't work in if-else blocks.
image image

The bug will always stop the entire script.
image image image

I tested it on versions 8.1.6 and 9.0.5 (because these happened to be the versions I had on my computer) and the bug only occurs in 9.0.5, so it's probably caused by the new variadic IF or the changes made for the THIS block to work.

@jmoenig jmoenig self-assigned this Sep 14, 2023
@jmoenig jmoenig added the bug label Sep 14, 2023
@jmoenig
Copy link
Owner

jmoenig commented Sep 14, 2023

thank you! I can reproduce and confirm this to be a bug. A quick investigation lets me agree with your assessment that this is likely caused by the recent changes to variadic conditional IF.

@jmoenig
Copy link
Owner

jmoenig commented Sep 14, 2023

I've just patched Snap v9.0.6 with a fix for this, my own test cases - and the ones you reported - all seem to pass now. Can you please confirm? Again, thank you for this very attentive and thoughtful bug report!

@gustav-langer
Copy link
Author

Seems to be fixed now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants