Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiv animation jumping #29

Open
jjkaufman opened this issue Jan 4, 2019 · 2 comments
Open

Wiv animation jumping #29

jjkaufman opened this issue Jan 4, 2019 · 2 comments
Assignees

Comments

@jjkaufman
Copy link
Owner

Have an idea to reduce jumpiness of wiv animation on the extreme examples.

I think many intersection points exist. Will try to find the intersection point with the min distance with the last intersection point

@jjkaufman jjkaufman self-assigned this Jan 4, 2019
@jjkaufman
Copy link
Owner Author

Idea didn't workout due to the result overlapping / getting messy

Pivoted to detection of "extreme conditions" and reverting to old logic. Still trying to figure out the equation for extreme conditions. something with tightness and height

@bendemeyer
Copy link
Collaborator

Honestly I don't mind the big jumps that much. In fact I'm starting to sort of like them.

What I don't like is the shaky-ness and slight overlap that happens on all the corners, but the bottom-right corner especially. I feel like that's something we may need a JS animation expert to understand/fix though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants