This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
feat: improve parsing of unlabeled CSVs #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMMilliken
requested review from
gmastrapas,
guenthermi,
bwanglzu and
matousek-martin
matousek-martin
approved these changes
Feb 24, 2023
LMMilliken
force-pushed
the
feat-binary-relevance-judgement
branch
from
90d1f1f
to
feef2c1
Compare
guenthermi
suggested changes
Feb 28, 2023
| `This is an English sentence`, `Das ist ein englischer Satz` and `Dit is een Engelse zin` will all be given the same label. | ||
|
|
||
| ```` | ||
|
|
There was a problem hiding this comment.
maybe it is better to roll out the tabs, since it is not just the same thing with small modification. The content is rather different in all tabs
There was a problem hiding this comment.
im not sure I understand, do you mean use tabs for all the example CSVs?
There was a problem hiding this comment.
I mean rather remove all tabs
|
📝 Docs are deployed on https://ft-feat-binary-relevance-judgement--jina-docs.netlify.app 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adjusts the
load_finetuning_datasetmethod to parse unlabeled CSV files in a way that removes duplicate documentsThis pr does not implement support for binary relevance judgement exactly, instead it changes the way unlabeled data is parsed to achieve the same result. The formats that users can provide their data in has not changed, only the DocumentArrays that are returned.
For an unlabeled data provided in this format:
We previously would have returned a document array with 14 elements (4 duplicates) and 7 classes, now we will return a document array with 10 elements and 3 classes