Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix build encoding dataset #623

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Fix build encoding dataset #623

merged 1 commit into from
Nov 30, 2022

Conversation

LMMilliken
Copy link
Contributor

@LMMilliken LMMilliken commented Nov 28, 2022

Currently, attempting to encode data from a list using a CLIP model made using get_model will result in an error, this pr prevents that by changing the method of determining the inferring the modality of the model


  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@LMMilliken LMMilliken marked this pull request as ready for review November 28, 2022 13:38
@github-actions
Copy link

📝 Docs are deployed on https://ft-fix-build-encoding-dataset--jina-docs.netlify.app 🎉

@LMMilliken LMMilliken marked this pull request as draft November 28, 2022 15:06
@LMMilliken LMMilliken marked this pull request as ready for review November 29, 2022 08:32
@LMMilliken LMMilliken self-assigned this Nov 29, 2022
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmastrapas gmastrapas merged commit 49ae3b7 into main Nov 30, 2022
@gmastrapas gmastrapas deleted the fix-build-encoding-dataset branch November 30, 2022 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants