Excise Pkg and UUIDs
#544
Merged
Excise Pkg and UUIDs
#544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to a conversation on Slack in the
#ttfxchannel.In version 1.11, depending on Pkg.jl will no longer be free because it's not in the sysimage, this makes GR.jl slower to load on v1.11 than v1.10.
The code in GR.jl that uses Pkg is non-functional, since doing a
@eval using QMLwhen QML.jl isn't in the dep-list will just cause an error. This has probably been failing the entire time this code existed, but wasn't noticed because it's wrapped in atry/catchblock without even a@debugstatement.This PR alone is not enough to fix the ttfx regression for GR in v1.11, since some of the binary artifacts like the
Xorgstack also are loading Pkg, but those are apparently being dealt with as well.