Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - character must be non-negative in JAS issues with a location value of 0 #472

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Apr 24, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

[ERR - 18:12:36] Error: Illegal argument: character must be non-negative

There is a different mapping that vscode expects as positions at file.
For vscode the minimum value (i.e first row/col) is 0 while the results mapped to it is 1 from the scanners.

Fixing a bug that occurs when issues discovered at JAS scans (CA and secrets) have a location with row/col 0:

"region": {
      "snippet": {
             "text": "*******"
      },
      "endColumn": 0,
      "endLine": 3,
      "startColumn": 0,
      "startLine": 3
},

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Apr 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 24, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Apr 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 25, 2024
@attiasas attiasas changed the title Fix viewing JAS issues at the location 0 Fix - character must be non-negative in JAS issues with a location value of 0 Apr 25, 2024
@attiasas attiasas merged commit 216b35a into jfrog:master Apr 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants