Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ums): introduce currentUser #197

Merged
merged 4 commits into from
Dec 17, 2020
Merged

feat(ums): introduce currentUser #197

merged 4 commits into from
Dec 17, 2020

Conversation

reinos
Copy link
Contributor

@reinos reinos commented Dec 17, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our conventions
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently there is no way to get the current user that is logged.

Issue Number: N/A

What is the new behavior?

This PR introduce

  • a new api method to get the current logged-in user via ums.isLoggedIn([alias: optional]).subscribe()
  • changed the ums.signIn() to return the current user that has been logged in, instead of the token. Tokens are no concern of the user as it will handle all by the SDK.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

The ums.signIn() method will not return a token anymore, but instead of that. It will return the current user.

@reinos reinos self-assigned this Dec 17, 2020
@reinos reinos added the enhancement New feature or request label Dec 17, 2020
@reinos reinos marked this pull request as ready for review December 17, 2020 08:43
@reinos reinos requested a review from veger December 17, 2020 08:57
@reinos reinos merged commit db0d25d into master Dec 17, 2020
@reinos reinos deleted the feat/get-current-user branch December 17, 2020 12:44
miss-tique pushed a commit that referenced this pull request Dec 17, 2020
# [5.9.0](v5.8.0...v5.9.0) (2020-12-17)

### Features

* **ums:** introduce currentUser ([#197](#197)) ([db0d25d](db0d25d))
@miss-tique
Copy link

🎉 This PR is included in version 5.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants