Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(queries): migrate data queries to the observables #134

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

KutsenkoA
Copy link
Contributor

@KutsenkoA KutsenkoA commented Dec 18, 2019

Old data request syntax:

dataet.select()
  .execute()
  .then(result => {
     // enjoy your result
   })
  .catch(error => // do something with error)

new syntax:

dataset.select()
  .subscribe(result => {
    // enjoy your result
  }, error => // do something with error);

@KutsenkoA KutsenkoA self-assigned this Dec 18, 2019
@KutsenkoA KutsenkoA added the feature New feature is introduced label Dec 18, 2019
extra_docs/dataset/README.md Outdated Show resolved Hide resolved
extra_docs/dataset/README.md Outdated Show resolved Hide resolved
extra_docs/dataset/README.md Outdated Show resolved Hide resolved
extra_docs/dataset/README.md Outdated Show resolved Hide resolved
extra_docs/dataset/README.md Outdated Show resolved Hide resolved
extra_docs/dataset/README.md Outdated Show resolved Hide resolved
extra_docs/dataset/README.md Outdated Show resolved Hide resolved
extra_docs/dataset/README.md Outdated Show resolved Hide resolved
src/api/core/queries/baseQuery.spec.ts Outdated Show resolved Hide resolved
src/api/core/queries/baseQuery.ts Show resolved Hide resolved
@KutsenkoA KutsenkoA force-pushed the JEXIA-2804/make-queries-return-observable branch from d2daec6 to 8b7d18b Compare December 20, 2019 12:42
@KutsenkoA KutsenkoA merged commit bd8143f into master Dec 20, 2019
@KutsenkoA KutsenkoA deleted the JEXIA-2804/make-queries-return-observable branch December 20, 2019 13:33
miss-tique pushed a commit that referenced this pull request Dec 20, 2019
# [4.3.0](v4.2.4...v4.3.0) (2019-12-20)

### Features

* **queries:** migrate data queries to the observables ([#134](#134)) ([bd8143f](bd8143f))
@miss-tique
Copy link

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature is introduced released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants