[perf] Install all packages to profile in a single nix command #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcurtis
approved these changes
Jun 7, 2024
savil
reviewed
Jun 7, 2024
mohsenari
pushed a commit
that referenced
this pull request
Jun 10, 2024
## Summary This change installs all packages into profile with same command. If we fail due to priority conflict, we fallback to the previous one by one installation. This significantly improves performance on projects with many packages when all packages are already in store. This aims to solve a common CICD case where nothing has changed, all packages are in store, but we need to create the .devbox directory and nix profile from scratch. cc: @Lagoja this helps address some reported issues. ## How was it tested? Happy path: On project with 30+ packages, delete `.devbox` directory and ran `devbox install`. This change reduced total time from 10s to 2s. Sad path: On new project added `curl`, `ruby`, `bundler`, `go`. `ruby` and `bundler` conflict. I ran `devbox install` and it correctly fell back to one by one. I inspected the profile to ensure nix did not install anything twice.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change installs all packages into profile with same command. If we fail due to priority conflict, we fallback to the previous one by one installation.
This significantly improves performance on projects with many packages when all packages are already in store. This aims to solve a common CICD case where nothing has changed, all packages are in store, but we need to create the .devbox directory and nix profile from scratch.
cc: @Lagoja this helps address some reported issues.
How was it tested?
Happy path:
On project with 30+ packages, delete
.devboxdirectory and randevbox install. This change reduced total time from 10s to 2s.Sad path:
On new project added
curl,ruby,bundler,go.rubyandbundlerconflict. I randevbox installand it correctly fell back to one by one. I inspected the profile to ensure nix did not install anything twice.