[docker] Added fix to run image release on tags creation + backfill action #2118
Conversation
There was a problem hiding this comment.
I'm a bit confused by this action. It doesn't seem like the version is added to the image at all? Is this just meant to refresh the latest image? (DEVBOX_USE_VERSION is not set, so it looks like no matter what the docker image will use the latest version)
Also, are the actions identical? You should just add workflow_dispatch to existing one and can have ref defaulted correctly.
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| myCommit: |
There was a problem hiding this comment.
This should be called ref or tag
The repo checkout action checks out the code at the provided tag. But good point on not having
The actions are similar but not identical. Frankly, I don't know how I can branch the logic in a YAML file to do the current tag and update latest if inputs aren't provided. This action can be deleted once we successfully backfill the older devbox versions in dockerhub |
There was a problem hiding this comment.
What I had in mind was something like 8543619
I'm still a bit confused about what we're doing with versions. Currently, every time a tag is pushed we publish a latest without a version. I guess this is fine (it basically helps update the launcher, etc)
This does mean we don't really need to "backfill" anything. We've never actually published individual tags. I think just adding workflow_dispatch to the existing job is probably enough.
For future thought:
Ideally we publish latest only for newest tag (there's a latest=auto on the docker meta action, but I'm not sure how it works). In addition we also publish each individual tag with the env variable. Ideally we also pre-install the binary on the docker image so it doesn't need to be installed after the container is initialized.
| @@ -1,5 +1,8 @@ | |||
| FROM debian:stable-slim | |||
|
|
|||
| # Optional arg to install custom devbox version | |||
| ARG DEVBOX_VERSION | |||
There was a problem hiding this comment.
Just name this DEVBOX_USE_VERSION. No need to use 2 different names.
| @@ -1,5 +1,8 @@ | |||
| FROM debian:stable-slim | |||
|
|
|||
| # Optional arg to install custom devbox version | |||
| ARG DEVBOX_VERSION | |||
Summary
Github action for releasing docker images to dockerhub didn't run when we created a new tag (0.11.0) this fixes that issue.
Plus I added a new github action that can only be triggered manually. It takes inputs for tag/version name and releases docker image to dockerhub at that specific tag. This is to backfill older versions of devbox to dockerhub as well.
How was it tested?
Will have to be tested via github actions run on a tag creation. But backfill will be tested manually