[cache] Fallback for failed build with cache #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
May 24, 2024
| @@ -516,7 +529,6 @@ func (d *Devbox) installNixPackagesToStore(ctx context.Context, mode installMode | |||
| args.AllowInsecure = allowInsecure | |||
| err = nix.Build(ctx, args, installables...) | |||
| if err != nil { | |||
| color.New(color.FgRed).Fprintf(d.stderr, "Fail\n") | |||
There was a problem hiding this comment.
is deleting this a good idea for non-nixcache scenarios (i.e. the common scenario)?
There was a problem hiding this comment.
Yeah, we print error a few times (once for nix stderr, and once for devbox failing) so this was a third error (and not very informative because it was just fail). The nix output tends to be the most informative.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How was it tested?
Ran install on devbox project that installs cached terraform. Commented out
--extra-substitutersflag to force it to fail. Observed output indicating substituter error, and fallback to building from source.