internal/nix: support older nix versions in DaemonVersion #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To check if nix daemon is running, Devbox runs: nix store info --json --store daemon This fails on older versions of Nix for a couple reasons: - Before Nix 2.19.0, `nix store info` was `nix store ping`. - Before Nix 2.14.0, the `--json` flag wasn't supported. Check for both of these versions when constructing the `nix store` command so it works for Nix versions 2.12 - 2.21+. Also add a `nix.VersionInfo.AtLeast` method and constants to make checking for supported major Nix versions easier.
gcurtis
force-pushed
the
gcurtis/daemon-versions
branch
from
6f570ea
to
c1fcdeb
Compare
mikeland73
approved these changes
Apr 26, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check if nix daemon is running, Devbox runs:
This fails on older versions of Nix for a couple reasons:
nix store infowasnix store ping.--jsonflag wasn't supported.Check for both of these versions when constructing the
nix storecommand so it works for Nix versions 2.12 - 2.21+.Also add a
nix.VersionInfo.AtLeastmethod and constants to make checking for supported major Nix versions easier.Tested by running the
nix storecommands on all supported Nix versions.