Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade micromatch to avoid security vulnerability #6040

Closed
ehmicky opened this issue Apr 20, 2018 · 9 comments · Fixed by #6400
Closed

Upgrade micromatch to avoid security vulnerability #6040

ehmicky opened this issue Apr 20, 2018 · 9 comments · Fixed by #6400

Comments

@ehmicky
Copy link
Contributor

ehmicky commented Apr 20, 2018

[Feature request] Upgrade dependency

Jest including some of its sub-packages like jest-message-utils depend on micromatch version 2.3.11, which itself depends on braces version 1.8.5.

That version of braces has a RegExp vulnerability. This causes Jest and some of its sub-packages to be reporter by vulnerabilities tools like Snyk.

Upgrade all the packages that depend on micromatch to the latest version would solve that issue.

@thymikee
Copy link
Collaborator

Isn't the security update within semver range? If so, simply installing Jest once again should solve the issue.

@ehmicky
Copy link
Contributor Author

ehmicky commented Apr 20, 2018

The dependency is currently micromatch@^2.3.11 which should resolve to 2.3.11 (the last version in 2.*.*). micromatch 2.3.11 depends on braces@^1.8.2 which resolves to 1.8.5.

This is also why Snyk is reporting a vulnerability.

Please correct if I'm wrong or I missed something.

@thymikee
Copy link
Collaborator

Oh, we need to update to micromatch 3 then

@ehmicky
Copy link
Contributor Author

ehmicky commented Apr 20, 2018

Yes, sorry should have made that clearer.

@wtgtybhertgeghgtwtg
Copy link
Contributor

If I'm remembering right, both jest and babel use micromatch@2 because micromatch@3 has a transitive dependency that doesn't bundle correctly. So this can't be fixed until micromatch/micromatch#122 get done.

@SimenB
Copy link
Member

SimenB commented Apr 21, 2018

Correct, we're blocked on the bundling issue I've reported.

We might want to switch out rollup if it unblocks us

@JoshuaKGoldberg
Copy link
Contributor

....and micromatch@3 breaks Windows. #6546

@SimenB
Copy link
Member

SimenB commented Jul 8, 2018

@JoshuaKGoldberg see #6650

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants