Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support case insensitive searches #10

Closed
kristiehowboutdat opened this issue Jun 25, 2018 · 4 comments
Closed

Support case insensitive searches #10

kristiehowboutdat opened this issue Jun 25, 2018 · 4 comments
Labels
good first issue Good for newcomers

Comments

@kristiehowboutdat
Copy link

Thanks for your hard work on this! It's been a really useful addition to my jest workflow.

My only "complaint" currently is that all of my component files are PascalCased, and I always type my watch queries in lowercase

Feature request: case-insensitive searches:

ex. nav AND Nav should show results for components/NavBar/, where currently, components/NavBar only shows up for Nav

Are there reasons not to do this? Happy to help with a PR if possible

@thymikee
Copy link
Member

Sounds like a great opportunity for first PR! Would be great to get this in :)

@thymikee thymikee added the good first issue Good for newcomers label Jun 25, 2018
@rogeliog
Copy link
Member

Thanks for reporting this @kristiehowboutdat!

I think it would be awesome to solve it at a Jest level, by adding configs to plugins.

See #9 (comment) for more info.

@rogeliog
Copy link
Member

rogeliog commented Jul 3, 2018

@kristiehowboutdat These should be the changes needed in Jest core to support this feature. jestjs/jest#6603

@rogeliog
Copy link
Member

rogeliog commented Jul 3, 2018

I was wrong, I apologize, my bad.

Although we would need configs eventually, it is not required for this.

aaa

I think we simply need to use the regex instead of the pattern https://github.com/jest-community/jest-watch-typeahead/blob/master/src/file_name_pattern_prompt.js#L98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants