Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Actively Selected Line Color #304

Closed
typkrft opened this issue Jan 27, 2022 · 8 comments
Closed

Change Actively Selected Line Color #304

typkrft opened this issue Jan 27, 2022 · 8 comments

Comments

@typkrft
Copy link

typkrft commented Jan 27, 2022

Is it possible to change the color of the actively selected line. It's extremely hard to see. I looked through the dock for color/text/line and other keywords to see if I could find anything, but did not. It's possible I missed something so I thought I'd post here instead of filing an bug/feature.

Thanks for the great software!

Picture for reference.
Default Settings, Dracula theme in kitty.
Screen Shot 2022-01-26 at 7 11 11 PM

@ThomasLachaux
Copy link

I also have the same problem with Nord Theme, and therefore, not usable. It is also discussed in the issue #243.

I wasn't able to find the code section where the selection color is applied. Does this depends from another library ?

@ThomasLachaux
Copy link

By the way, I've just forked the repo to add this option.
reverse

More info here #243 (comment)

@DanielPower
Copy link

DanielPower commented May 1, 2022

I'm also using Kitty terminal. With the Tokyo Night theme. For me it's also impossible to tell which line is selected.

Edit: For the Kitty users having this problem, I just realized that because I was specifying the font style in my config, applications were not able to specify font or italics.

Change (for example)
font_family Berkeley Mono Regular
to
font_family Berkeley Mono

And Lazydocker should be able to display bold text as expected.

@jesseduffield
Copy link
Owner

This is a solved problem in lazygit so implementing here should just be a matter of copy+pasting code (or perhaps extracting common code into a shared package).

If you look in pkg/theme/theme.go in https://github.com/jesseduffield/lazygit that's a good starting point.

@mbwhite
Copy link

mbwhite commented Jun 14, 2022

HI - I'm using WSL2, with the Windows terminal and I can't see any line highlighted... so would love to see this

@markhagemann
Copy link

Hey @mbwhite can you try setting intenseTextStyle to bold or all in your WSL2 profiles list.

image

It might complain about it not being a valid property in VSCode but it works for me and fixes the issue with lazygit / lazydocker in Windows Terminal Preview. I am not sure if this property has been brought into Windows Terminal default yet.

image

This is the issue where I found the solution:

microsoft/terminal#109

@jesseduffield
Copy link
Owner

I've made it so that the selected item has a blue background in #372

@jesseduffield
Copy link
Owner

#372 is merged to master. Let me know if you have any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants