stm32f7nucleo: Add ADC support #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
dd7040b
to
5427be8
Compare
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Jun 20, 2019
Aligned to configuration of NuttX: GPIO_ADC1_IN3 nuttx/configs/nucleo-144/src/stm32_adc.c (nuttx-7.21-298-gc67b807f43) More pins/channels may be configured later. Change-Id: I5407e6b9b91eaa8570713d0331f786441ce0c649 Relate-to: rzr/webthing-iotjs#3 Forwarded: jerryscript-project#1894 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
galpeter
requested changes
Jun 20, 2019
|
|
||
| // ADC pin name is "ADC.(number)_(timer)". | ||
| #define SET_ADC_CONSTANT(number, timer) \ | ||
| number_bit = (GPIO_ADC##number##_IN##timer); \ |
There was a problem hiding this comment.
We should wrap the macro contents into a do { } while (0); block. Something like this:
#define SET_ADC_CONSTANT(number, timer) \
do { \
unsigned int number_bit = (GPIO_ADC##number##_IN##timer); \
.... \
} while (0);There was a problem hiding this comment.
Are you sure? because this macro is used by the other one
Code is aligned to STM32 discovery, but I can try to improve both later
| return stm32_adcinitialize(number, channel_list, 1); | ||
| #elif defined(TARGET_BOARD_STM32F7NUCLEO) | ||
| return stm32_adc_initialize(number, channel_list, 1); |
There was a problem hiding this comment.
If I remember correctly this function name comes from nuttx, am I correct?
There was a problem hiding this comment.
yes but it has a different naming for STM32F7, Maybe I will also try to align in nuttx codebase too but AFAIK each port is free to define its own functions.
| static void iotjs_pin_initialize_adc(jerry_value_t jobj) { | ||
| unsigned int number_bit; | ||
|
|
||
| // ADC pin name is "ADC.(number)_(timer)". |
There was a problem hiding this comment.
Is this comment ok? Based on the property set below, the name is ADC<number>_<timer>, there is no . in the name.
There was a problem hiding this comment.
Good catch, I will fix this in discovery file too
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
5427be8
to
060e841
Compare
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Jun 20, 2019
Aligned to configuration of NuttX: GPIO_ADC1_IN3 nuttx/configs/nucleo-144/src/stm32_adc.c (nuttx-7.21-298-gc67b807f43) More pins/channels may be configured later. Change-Id: I5407e6b9b91eaa8570713d0331f786441ce0c649 Relate-to: rzr/webthing-iotjs#3 Forwarded: jerryscript-project#1894 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
Aligned to configuration of NuttX: GPIO_ADC1_IN3 nuttx/configs/nucleo-144/src/stm32_adc.c (nuttx-7.21-298-gc67b807f43) More pins/channels may be configured later. Also handle difference per processors (this could be aligned in NuttX codebase). Change-Id: I5407e6b9b91eaa8570713d0331f786441ce0c649 Relate-to: rzr/webthing-iotjs#3 Forwarded: jerryscript-project#1894 IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
060e841
to
f3679c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned to configuration of NuttX: GPIO_ADC1_IN3
nuttx/configs/nucleo-144/src/stm32_adc.c
(nuttx-7.21-298-gc67b807f43)
More pins/channels may be configured later.
Change-Id: I5407e6b9b91eaa8570713d0331f786441ce0c649
Relate-to: rzr/webthing-iotjs#3
Forwarded: https://github.com/pando-project/iotjs/pull/
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com