Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import twins to iotjs-modules #5

Merged

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Nov 8, 2019

Origin: https://github.com/rzr/twins
Relate-to: https://social.samsunginter.net/@rzr/102139995659879619
Bug: https://github.com/jerryscript-project/iotjs-modules/pull
Change-Id: Ic054437864b54a2f95d47f393da796d7d2daefa2
IoT.js-Modules-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com

Origin: https://github.com/rzr/twins
Relate-to: https://social.samsunginter.net/@rzr/102139995659879619
Bug: jerryscript-project#5
Change-Id: Ic054437864b54a2f95d47f393da796d7d2daefa2
IoT.js-Modules-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
@rzr rzr force-pushed the sandbox/rzr/review/master branch from a7882bb to bf56bc1 Compare November 8, 2019 15:08
Copy link

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzr
Copy link
Contributor Author

rzr commented Mar 6, 2020

I'll may update more packages once this one is merged

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit c4b9ce5 into jerryscript-project:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants