-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dolby Vision Profile 5 does not play correctly (DirectPlay) #1772
Comments
Bump. I'm happy to help debug and/or fix this if someone can help point me in the right direction. |
Nothing jumps out to me that could be causing this but I also don't use HDR. Note that your device has two versions, Roku Ultra and Roku Ultra LT. The Roku Ultra LT also supports HDR10+. Here's the docs for HEVC - https://developer.roku.com/en-ca/docs/specs/media/streaming-specifications.md#supported-video-codecs A good first step when debugging video files, is to see if roku's own media player can play the file correctly. If that can't play the file, then neither can our app. |
@cewert - I have the non-LT. I mentioned this in the "Additional Context", but Roku Media Player can play the video files just fine. My theory is that for some reason in the Jellyfin app, it's trying to play the video as non-HDR, so it's decoding the colors incorrectly. I believe that the HDMI link has to specify the color range, so maybe there's some command that sets the Roku into an HDR mode? |
There's no HDR flag to toggle that I'm aware of. Thanks for the testing info. That explains why your colors are off but I'm not sure what the fix is at this time. |
Can you give me a rough idea where in the code the video player is set up? I'll try messing around with it and see if I can get anywhere. |
Bumping. I made a slightly interesting discovery today - this issue doesn't impact regular HDR videos. Just DoVi. No idea why but maybe that helps narrow things down. |
Just triple checking, does the server indicate that it's direct playing? Or is it transcoding / remuxing by chance? |
Direct play |
@cewert - are you ok with me putting a bounty on this? |
I'll try to dig in a bit more now that I've got the dev stuff set up, but in the meantime - I'm going to put up $100 for anyone who can fix this (with permission of maintainers) |
@kaysond what does it say under roku settings -> Display type? |
Automatic 4k Dolby Vision |
Software Versions
Describe the bug
When playing a video with the following profile, the colors have a green/purple hue, as if the setup does not actually support HDR, when it in fact does.
How To Reproduce
Expected behavior
Video should play as HDR
Logs
Server debug log: https://hastebin.com/share/omiqezupev.yaml
Screenshots
Connection Information
Local over https
Additional context
I'm playing this on a Roku 4800X which supports the above video profile. If I use Roku Media Player to play the file, it works just fine, and my TV shows "HDR". With Jellyfin, "HDR" does not show up, and I get the incorrect colors. I suspect the Roku is trying to play it as SDR. Maybe there's some kind of hint that has to be given to the player API to decode it as HDR?
The text was updated successfully, but these errors were encountered: