address memory usage issue in time.After() #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed a continuous increase in memory usage when making heavy use of the cache with a long global TTL set. My usage pattern was mostly setting and quickly deleting values again (manually), and my intention was to use the TTL only to purge corner cases which were not cleaned up by my own code.
Profiling revealed that the memory in use is mostly timers:
This was likely to a common quirk with
time.After()
, see e.g. [1] and more.Some minor refactoring (see diff) resulted in the same behaviour but without excessive memory usage. Tests complete with no problem.[1] https://medium.com/@oboturov/golang-time-after-is-not-garbage-collected-4cbc94740082