Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is menu ready for stable yet? #183

Open
westphaldp opened this issue May 2, 2019 · 1 comment
Open

Is menu ready for stable yet? #183

westphaldp opened this issue May 2, 2019 · 1 comment

Comments

@westphaldp
Copy link

westphaldp commented May 2, 2019

I tried to get it to work with Rust stable for days and had to find out that it's unfortunately not possible right now.

All menu library functions are behind a feature gate meaning that ncurses-rs as it is right now still compiles with Rust stable and won't break for anyone. It's like an opt-in extra feature for those using rust nightly.

But if you really don't want any unstable code in ncurses-rs you may also wait until the CString reform lands in Rust stable.

Originally posted by @tsurai in #87 (comment)

Being new to Rust, I can't be sure, but it looks like CString is stable now. Can we remove the nightly requirement?

@tsurai
Copy link
Contributor

tsurai commented May 3, 2019

You are right. I've done a short test and everything seems to work fine when compiling it with stable. Should be ok to remove the notice saying that it requires nightly at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants