Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in TsDomain/TsPeriodSelector #349

Open
Immurb opened this issue Oct 16, 2018 · 0 comments
Open

Inconsistency in TsDomain/TsPeriodSelector #349

Immurb opened this issue Oct 16, 2018 · 0 comments

Comments

@Immurb
Copy link
Member

Immurb commented Oct 16, 2018

I discovered that TsDomain and TsPeriodSelector handle negative values for "Last" and "First" different from "Excluding". For "Excluding" the input '-X' means 'X years' which is consistent with the behaviour of other specifications e.g. "Forecasts horizon". For "Last" and "First" it is an invalid input and not the 'last/first X years'.
Is there any reason for that?

Besides the documentation for the method "excluding" is incorrect as it states that the input has to be "Greater or equal to 0."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant