Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: use ! to indicate mutating functions #2

Open
digital-carver opened this issue Sep 22, 2021 · 1 comment
Open

Suggestion: use ! to indicate mutating functions #2

digital-carver opened this issue Sep 22, 2021 · 1 comment

Comments

@digital-carver
Copy link

It looks like the remove_* functions and clean_text mutate their docx argument. If so, it would be useful and expected to follow the usual Julia convention of ending the function names in ! to indicate that they're mutating functions. So for eg. remove_puncts!(...), clean_text!(...), etc.

@Jcharis
Copy link
Member

Jcharis commented Sep 22, 2021

Thanks a lot @digital-carver. I appreciate this 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants