This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Prep for NFL playoff 2023 edition #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am EST. 1 day redemption period. game starts Jan 14 12am EST. voting starts the day of the superbowl, scorecards dont have a voting duration. mints are 0.1 ETH.
mejango
changed the title
mejango
commented
Dec 31, 2022
viraj124
approved these changes
Jan 3, 2023
xBA5ED
reviewed
Jan 3, 2023
contracts/DefifaGovernor.sol
Outdated
| */ | ||
| function attestToScorecard(uint256 _scorecardId) external override { | ||
| // Vote. | ||
| super._castVote(_scorecardId, msg.sender, 1, ''); |
There was a problem hiding this comment.
Nit: Having the UI call castVoteWithReasonAndParams (with the ordered tier ids of the user) is cheaper than calling castVote, could be a nice gas savings.
There was a problem hiding this comment.
maybe we have a 2nd option as attestToScorecardWithSig ?
…e-defifa into game/NFL-playoffs-2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed trade deadline. added refund period. mint starts Jan 8 12am EST. 1 day refund period. game starts Jan 14 12am EST. voting starts the day of the superbowl, scorecards dont have a voting duration. mints are 0.1 ETH.