You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
In the documentation related to this projects signals the following text, "Sent before saving historical record", is printed by the pre_create_historical_record signal. However, this verbiage is wrong. It does not happen "before saving historical record". It happens before the creation of the historical record ( before the saving of the respective base object )".
I would like to change this verbiage to more accurately reflect whats happening.
Expected behavior
That code should execute before the creation of the historical record, not before "saving" the historical record
Screenshots
N/A
Environment (please complete the following information):
N/A
Additional context
Please allow me to make the fix as I'd like to start contributing to the project. I want to learn the contribution workflow. Ive already made the changes in this commit 8993d85
If anyone wants to suggest a different wording let me know and Ill update the PR. This actually caused confusion for me because I have the following code
Describe the bug
In the documentation related to this projects signals the following text, "Sent before saving historical record", is printed by the pre_create_historical_record signal. However, this verbiage is wrong. It does not happen "before saving historical record". It happens before the creation of the historical record ( before the saving of the respective base object )".
I would like to change this verbiage to more accurately reflect whats happening.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
That code should execute before the creation of the historical record, not before "saving" the historical record
Screenshots
N/A
Environment (please complete the following information):
N/A
Additional context
Please allow me to make the fix as I'd like to start contributing to the project. I want to learn the contribution workflow. Ive already made the changes in this commit 8993d85
If anyone wants to suggest a different wording let me know and Ill update the PR. This actually caused confusion for me because I have the following code
and I was concerned it was going to create an infinite loop based off the word "saving" in the example
The text was updated successfully, but these errors were encountered: