Migrate to GitHub Actions #270
Conversation
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
+ Coverage 88.41% 89.96% +1.54%
==========================================
Files 26 26
Lines 1226 1226
Branches 107 107
==========================================
+ Hits 1084 1103 +19
+ Misses 111 91 -20
- Partials 31 32 +1
Continue to review full report at Codecov.
|
| - name: Upload coverage | ||
| uses: codecov/codecov-action@v1 | ||
| with: | ||
| name: Python ${{ matrix.python-version }} |
There was a problem hiding this comment.
The original command for Travis has a bunch of options which aren't used now:
codecov --required -X gcov fix pycov -f coverage.xml --flags ${TOXENV//-/ }
I've not looked those up, but it doesn't seem to have affected coverage? In fact, it's gone up a bit.
I don't think there's analogues for all those options with the action, but at least flags can be added in the with: section:
There was a problem hiding this comment.
Right, I looked at them, I only see --required easy to reply, with fail_ci_if_error = true.
-X to disable a feature seems to be not supported by the action.
coverage.xml is automatically found already.
--flags with the tox environment isn't useful anymore since in the new GHA test workflow the test matrix doesn't use TOXENV anymore, so couldn't be used. Unless I'm misunderstanding the notation of ${TOXENV//-/ }? Does this make sense to you?
There was a problem hiding this comment.
I'm also not sure what ${TOXENV//-/ } means, but I don't see any $TOXENV actually used in the old Travis CI file, so probably fine to skip 👍
Travis CI has a new pricing model which places limits on open source.
Many projects are moving to GitHub Actions instead, including Jazzband projects:
This is based on jazzband/contextlib2#26.
TODO:
JAZZBAND_RELEASE_KEYto the repo secrets.