Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Series type arg in .loc #612

Open
khusmann opened this issue Nov 1, 2023 · 0 comments
Open

Missing Series type arg in .loc #612

khusmann opened this issue Nov 1, 2023 · 0 comments

Comments

@khusmann
Copy link

khusmann commented Nov 1, 2023

Describe the bug
Series.loc can accept a series of bools, but this is not reflected in the type signature.

This shows a type error in VSCode:

const dfd = require("danfojs-node")


let s = new dfd.Series([12, 34, 2.2, 2, 30, 30, 2.1, 7])
s.loc(s.gt(20)).print()

Error:

Argument of type 'Series' is not assignable to parameter of type '(string | number | boolean)[]'

Expected behavior
No type errors :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant