This repository has been archived by the owner on Jul 29, 2020. It is now read-only.
Lots of code cleanup #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 681296e did this only for clang, but GCC has the same warning which we want to supress (until the code is fixed).
Errors from various called functions were stored in the `ret` variable, but this variable was never checked.
This macro depends on the macro `max()` which is not provided by this library.
After commit 52cb87e, jpc_dec_dump() kept on using `PRIiFAST32`, but in 32 bit mode, this should be `PRIiLEAST32`. The new macro `PRIjas_seqent` can be used instead.
Fixes `-Wunused-but-set-variable`.
This doesn't avoid anything.
`hc` can only be `0` or `1` here. This fixes `-Wmaybe-uninitialized`.
`-Wimplicit-fallthrough`.
Similar to commit f3d4075 but for GCC this time.
theta682
reviewed
Jul 14, 2020
| @@ -972,6 +976,8 @@ static void render() | |||
| if (cmdopts.verbose) { | |||
| // fprintf(stderr, "vtlx=%f, vtly=%f, vsx=%f, vsy=%f\n", | |||
| // vtlx, vtly, gs.sx, gs.sy); | |||
| /* suppress -Wunused-but-set-variable */ | |||
| (void)vtlx; (void)vtly; | |||
There was a problem hiding this comment.
I recommend to split statements Declare one name (only) per declaration
Suggested change
| (void)vtlx; (void)vtly; | |
| (void)vtlx; | |
| (void)vtly; |
There was a problem hiding this comment.
I agree on this one. It makes it more readable to me. But I don't care much and can merge anyways.
There was a problem hiding this comment.
This isn't supposed to be "readable". This is a kludge to work around a compiler warning for code which is commented out for unknown reasons. Usually, I wouldn't write two statements on one line, but in this case I decided to do so because I didn't want to waste any screen space for this cr*p.
There was a problem hiding this comment.
Not sure whether this is a good reason to break with the style ;)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All gcc/clang warnings are now fixed.