Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--cap-lints should be set for sysroot builds #162

Open
RalfJung opened this issue Aug 22, 2017 · 2 comments
Open

--cap-lints should be set for sysroot builds #162

RalfJung opened this issue Aug 22, 2017 · 2 comments

Comments

@RalfJung
Copy link
Collaborator

Cargo automatically sets --cap-lints=allow when building dependencies to make sure that e.g. deny(warnings) in a dependency does not break the build. The same should happen when xargo builds the sysroot. xargo has to take care of this itself as cargo cannot know that e.g. the build of std actually is just building a dependency.

@RalfJung
Copy link
Collaborator Author

Once rust-lang/cargo#4423 is fixed, xargo could use RUSTFLAGS (or whatever new environment variable will control build scripts) to set --cap-lints=allow -- a rather straight-forward patch. Until then though it seems we could only set --cap-lints for the actual libraries that cargo compiles for xargo, but not for the build scripts. (And that doesn't help with my current problem, which involves build scripts failing to build.)

@japaric
Copy link
Owner

japaric commented Aug 22, 2017

--cap-lints should be set for sysroot builds

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants