NPM Release #16
Merged
NPM Release #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was based on viewport width before which led to broken layout of small ptable on wide pages
…omponent and passed in as prop, same for scatter plot also add props color_map, log, color_scale (latter for binding)
janosh
added a commit
that referenced
this pull request
Jan 3, 2023
* scale ptable font sizes based on container queries was based on viewport width before which led to broken layout of small ptable on wide pages * fix color mismatch for elem categories in stores.ts vs app.css * add src/lib/index.ts default+named exports * package.json add test:unit + test:e2e scripts * improve sep of concerns: heatmap values now computed outside ptable component and passed in as prop, same for scatter plot also add props color_map, log, color_scale (latter for binding) * add 1k separators in pretty_num() * fix tests, add scatter plot props y_label, y_unit * pnpm add -D @sveltejs/package and script 'package' * add release job to test.yml * add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish this project to NPM. Involves making components more re-usable by adding props for heatmap values to
PeriodicTable.svelteandScatterPlot.svelte(improves separation of concerns, was too tightly coupled to demo site use case).