Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump h3 version #207

Open
dylankbuckley opened this issue Sep 4, 2023 · 7 comments
Open

Bump h3 version #207

dylankbuckley opened this issue Sep 4, 2023 · 7 comments
Labels
dependencies Pull requests that update a dependency file enhancement good-first-issue help wanted

Comments

@dylankbuckley
Copy link

h3 pre-release: https://pypi.org/project/h3/4.0.0b2/. bumping to avoid conflicts with projects using latest h3 versions

@jannikmi
Copy link
Owner

jannikmi commented Sep 4, 2023

Thanks for bringing this up.
It seems like v4 introduces a lot of breaking changes:

FAILED tests/shortcut_test.py::test_resolutions - AttributeError: module 'h3.api.numpy_int' has no attribute 'h3_get_resolution'
FAILED tests/shortcut_test.py::test_unique_pole_cells - AttributeError: module 'h3.api.numpy_int' has no attribute 'h3_get_resolution'

I think at the moment it is too early to force h3>=4
Would you be willing to raise a PR for supporting both v3 and v4 API?

@dylankbuckley
Copy link
Author

Yeah - I should have some time to work on this tomorrow.

@jannikmi
Copy link
Owner

jannikmi commented Sep 4, 2023

Great!
Ideally you could also add tests for both h3 versions (ensuring to test backward compatibility)

@Gui-FernandesBR
Copy link

Hey, I recently tried to install timezonefinder on python 3.12 but it is not working due to a wheel problem of h3 package.
I've opened up an issue in their repo (uber/h3-py#326), attaching here to follow-up.

Given the above error, the timezonefinder project cannot be built on Python 3.12 yet.
Shall we open another issue here to address people having the same installation problem on 3.12?

@jannikmi
Copy link
Owner

Please open another issue for python 3.12 compatibility. Let's see if there are other problems apart from the h3 related build errors. We can keep track of the progress there.

@jannikmi
Copy link
Owner

@dylankbuckley Do you have any time to look into this?

@elbarbi
Copy link

elbarbi commented Sep 11, 2024

Hi everyone,
I am using both H3 and timezone finder. How's the issue progressing ?
I can maybe try to contribute on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement good-first-issue help wanted
Projects
None yet
Development

No branches or pull requests

4 participants