Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported keyword argument 'score_cast_func' to zrangebyscore() #193

Closed
fferrara opened this issue Jun 8, 2018 · 4 comments
Closed

Unsupported keyword argument 'score_cast_func' to zrangebyscore() #193

fferrara opened this issue Jun 8, 2018 · 4 comments

Comments

@fferrara
Copy link
Contributor

fferrara commented Jun 8, 2018

In the latest version of redis-py, zrangebyscore() accepts a keyword argument called score_cast_func.

Fakeredis does not support it yet.

I'll do a PR ASAP.
@bmerry
Copy link
Collaborator

bmerry commented Jun 8, 2018

There are two PRs already, but they're incomplete. You can probably save some time/effort by finishing what they started.

@bmerry
Copy link
Collaborator

bmerry commented Jun 8, 2018

Closing because it's a duplicate of #44 (a complete PR would still be welcome though).

@bmerry bmerry closed this as completed Jun 8, 2018
@fferrara fferrara mentioned this issue Jun 8, 2018
Merged
@fferrara
Copy link
Contributor Author

fferrara commented Jun 8, 2018

Sorry, I didn't check the open PRs. I ended up by making my own complete PR in #194 , with one test. Not sure if it's enough to be merged

@bmerry
Copy link
Collaborator

bmerry commented Jun 8, 2018

Thanks, I'll take a look next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmerry @fferrara