Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linsert implementation is incomplete #165

Closed
bmerry opened this issue Nov 9, 2017 · 1 comment
Closed

linsert implementation is incomplete #165

bmerry opened this issue Nov 9, 2017 · 1 comment

Comments

@bmerry
Copy link
Collaborator

bmerry commented Nov 9, 2017

It

  • does not examine where (it only implements BEFORE)
  • does not handle the case of the pivot not being in the list.

I have a fix in a branch I am preparing for PR.
@bmerry bmerry mentioned this issue Nov 9, 2017
Merged
@bmerry
Copy link
Collaborator Author

bmerry commented Mar 22, 2018

Fixed in 0.10.1.

@bmerry bmerry closed this as completed Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmerry