Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Operator SDK version #69

Merged

Conversation

jpkrohling
Copy link
Contributor

This PR changes the operator SDK version to use a fixed version, along with the necessary changes to get it working with this new version.

This is part of #66.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

@jpkrohling
Copy link
Contributor Author

This change is Reviewable

@jpkrohling
Copy link
Contributor Author

@pavolloffay, would you like to review this one?

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #69   +/-   ##
======================================
  Coverage    99.3%   99.3%           
======================================
  Files          17      17           
  Lines         718     718           
======================================
  Hits          713     713           
  Misses          5       5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70b543b...4d43f68. Read the comment docs.

Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impossible to review :). I will trust to travis!

@jpkrohling
Copy link
Contributor Author

Don't mind the changes inside vendor, it's sufficient if you take a look at the other changes :)

@pavolloffay
Copy link
Member

it was a joke.. :)

@jpkrohling jpkrohling merged commit b675627 into jaegertracing:master Oct 16, 2018
andream16 pushed a commit to andream16/jaeger-operator that referenced this pull request Oct 17, 2018
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants