Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 'expose metrics port' to prevent 'failed to create or get service' error #462

Merged

Conversation

jpkrohling
Copy link
Contributor

This PR is a workaround for #461. A real solution is still not known.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

…vice' error

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #462 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files          64       64           
  Lines        3170     3170           
=======================================
  Hits         2906     2906           
  Misses        184      184           
  Partials       80       80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc88ee...8986729. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #462 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files          64       64           
  Lines        3170     3170           
=======================================
  Hits         2906     2906           
  Misses        184      184           
  Partials       80       80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc88ee...8986729. Read the comment docs.

@jpkrohling jpkrohling merged commit 5501283 into jaegertracing:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants