Initialise menu to include Log Out option when using OAuth Proxy #344
Conversation
Signed-off-by: Gary Brown <gary@brownuk.com>
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 89.81% 89.88% +0.07%
==========================================
Files 64 64
Lines 3014 3035 +21
==========================================
+ Hits 2707 2728 +21
Misses 207 207
Partials 100 100
Continue to review full report at Codecov.
|
| ] | ||
| }, | ||
| { | ||
| "label": "Log Out", |
There was a problem hiding this comment.
This would render the "Log out" right next to the "About" item, right? Are they aligned to the main options, or are they aligned to the right?
There was a problem hiding this comment.
Yes, both "About" and "Log Out" are rendered together on the right.
There was a problem hiding this comment.
Great! Looks good to me, then
|
@jpkrohling Seems like there may be a way to logout into the same tab - I'll take a look in case we can get this one into the release. |
… fix coverage Signed-off-by: Gary Brown <gary@brownuk.com>
objectiser
changed the title
|
@jpkrohling Fixed based on Yuri's suggestion - could you give it a try in minishift with |
|
Tested with the simplest.yaml and works great!
|
Adds menu (About sub-menu and Log Out) when OAuth Proxy configured.
Currently when selecting the Log Out button it opens another tab - this may require a change in jaeger-ui.
Signed-off-by: Gary Brown gary@brownuk.com