Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove index cleaner from prod-es-deploy example #314

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay ploffay@redhat.com

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@jpkrohling
Copy link
Contributor

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files          70       70           
  Lines        3173     3173           
=======================================
  Hits         2813     2813           
  Misses        246      246           
  Partials      114      114

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e4622...b815b0b. Read the comment docs.

@objectiser
Copy link
Contributor

@pavolloffay What is the reason for removing this? thought it would be required for a production/ES deployment?

@pavolloffay
Copy link
Member Author

It gets automatically enabled in normalized. The settings provided in example are wrong - it does not make sense to run it every 30min.

Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks.

@pavolloffay pavolloffay merged commit 6cd11d2 into jaegertracing:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants