Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed from 'size' to 'replicas' #271

Merged

Conversation

jpkrohling
Copy link
Contributor

@jpkrohling jpkrohling commented Mar 6, 2019

Closes #270 by adding a new 'replicas' property, while keeping backwards compatibility with the old 'size' property

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Contributor Author

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #271 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   88.91%   88.94%   +0.03%     
==========================================
  Files          68       68              
  Lines        2886     2895       +9     
==========================================
+ Hits         2566     2575       +9     
  Misses        211      211              
  Partials      109      109
Impacted Files Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go 100% <ø> (ø) ⬆️
pkg/deployment/query.go 100% <100%> (ø) ⬆️
pkg/deployment/collector.go 100% <100%> (ø) ⬆️
pkg/deployment/ingester.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcb26f4...465aec6. Read the comment docs.

@jpkrohling jpkrohling merged commit 9f69b83 into jaegertracing:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants