Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only ES data nodes to calculate shards #257

Merged

Conversation

pavolloffay
Copy link
Member

Resolves #253

Signed-off-by: Pavol Loffay ploffay@redhat.com

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@jpkrohling
Copy link
Contributor

This change is Reviewable

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@jpkrohling
Copy link
Contributor

Needs make format. Other than that, LGTM

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #257 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   89.31%   89.34%   +0.03%     
==========================================
  Files          62       62              
  Lines        2741     2749       +8     
==========================================
+ Hits         2448     2456       +8     
  Misses        189      189              
  Partials      104      104
Impacted Files Coverage Δ
pkg/storage/elasticsearch.go 80.53% <100%> (+0.71%) ⬆️
pkg/inject/sidecar.go 100% <0%> (ø) ⬆️
pkg/deployment/query.go 100% <0%> (ø) ⬆️
pkg/deployment/all-in-one.go 100% <0%> (ø) ⬆️
pkg/deployment/collector.go 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31a5be...6c4e7c9. Read the comment docs.

@pavolloffay pavolloffay merged commit 518ff29 into jaegertracing:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants