Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ES master certs #256

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

pavolloffay
Copy link
Member

Resolves #252

Signed-off-by: Pavol Loffay ploffay@redhat.com

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@jpkrohling
Copy link
Contributor

This change is Reviewable

@pavolloffay
Copy link
Member Author

The secret master-certs are not used by ES deployment nor by Jaeger

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #256 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   89.31%   89.31%   -0.01%     
==========================================
  Files          62       62              
  Lines        2742     2741       -1     
==========================================
- Hits         2449     2448       -1     
  Misses        189      189              
  Partials      104      104
Impacted Files Coverage Δ
pkg/storage/elasticsearch_secrets.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c9dac...dc0fb16. Read the comment docs.

@jpkrohling jpkrohling merged commit a31a5be into jaegertracing:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants