Move pkg/configmap to pkg/config/ui

[Atul9]

closes #146
Signed-off-by: Atul Bhosale atul1bhosale@gmail.com

[jpkrohling]

This change is 

[codecov]

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files          28       28           
  Lines        1267     1267           
=======================================
  Hits         1219     1219           
  Misses         37       37           
  Partials       11       11

Impacted Files	Coverage Δ
pkg/deployment/query.go	100% <ø> (ø)	⬆️
pkg/deployment/all-in-one.go	100% <ø> (ø)	⬆️
pkg/strategy/production.go	100% <ø> (ø)	⬆️
pkg/config/ui/ui.go	96.42% <ø> (ø)
pkg/strategy/all-in-one.go	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a738c3a...4331833. Read the comment docs.

[jpkrohling]

Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Atul9)

a discussion (no related file):
I believe there might be other places to change as well, as the e2e tests doesn't seem to be passing with this PR:

        --- FAIL: TestJaeger/jaeger-group/my-other-jaeger (30.85s)
            client.go:57: resource type RoleBinding with namespace/name (jaeger-jaeger-group-my-other-jaeger-1543913238/jaeger-operator) created
            client.go:57: resource type Role with namespace/name (jaeger-jaeger-group-my-other-jaeger-1543913238/jaeger-operator) created
            client.go:57: resource type ServiceAccount with namespace/name (jaeger-jaeger-group-my-other-jaeger-1543913238/jaeger-operator) created
            client.go:57: resource type Deployment with namespace/name (jaeger-jaeger-group-my-other-jaeger-1543913238/jaeger-operator) created
            jaeger_test.go:57: Initialized cluster resources. Namespace: jaeger-jaeger-group-my-other-jaeger-1543913238
            wait_util.go:51: Deployment available (1/1)
            client.go:57: resource type Jaeger with namespace/name (jaeger-jaeger-group-my-other-jaeger-1543913238/my-jaeger) created
            wait_util.go:45: Waiting for full availability of my-jaeger deployment (0/1)
            wait_util.go:45: Waiting for full availability of my-jaeger deployment (0/1)
            wait_util.go:51: Deployment available (1/1)
            client.go:57: resource type Jaeger with namespace/name (jaeger-jaeger-group-my-other-jaeger-1543913238/all-in-one-with-ui-config) created
            wait_util.go:87: Ingress available
            all_in_one_test.go:32: unexpected status code 503

---

[jpkrohling]

We might be getting bitten by kubernetes-retired/contrib#1718

Re-running the tests made it pass:

$ make test
Running unit tests...
?   	github.com/jaegertracing/jaeger-operator/cmd	[no test files]
?   	github.com/jaegertracing/jaeger-operator/cmd/manager	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/account	0.102s	coverage: 100.0% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/apis	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/apis/io/v1alpha1	0.046s	coverage: 18.8% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/cmd/start	[no test files]
?   	github.com/jaegertracing/jaeger-operator/pkg/cmd/version	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/config/sampling	0.024s	coverage: 94.1% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/config/ui	0.030s	coverage: 94.1% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/controller	[no test files]
?   	github.com/jaegertracing/jaeger-operator/pkg/controller/deployment	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/controller/jaeger	3.056s	coverage: 64.3% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/deployment	0.051s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/ingress	0.054s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/inject	0.029s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/route	0.022s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/service	0.007s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/storage	0.010s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/strategy	0.006s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/util	0.005s	coverage: 100.0% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/version	[no test files]
Formatting code...
Building...
Sending build context to Docker daemon     79MB
Step 1/4 : FROM alpine:3.8
 ---> 196d12cf6ab1
Step 2/4 : USER nobody
 ---> Using cache
 ---> 18305c5b670d
Step 3/4 : ADD build/_output/bin/jaeger-operator /usr/local/bin/jaeger-operator
 ---> f580452c2ebc
Step 4/4 : ENTRYPOINT ["/usr/local/bin/jaeger-operator"]
 ---> Running in 13e45020df2a
Removing intermediate container 13e45020df2a
 ---> 91e17e219036
Successfully built 91e17e219036
Successfully tagged jpkroehling/jaeger-operator:latest
Pushing image jpkroehling/jaeger-operator:latest...
mkdir -p deploy/test
Running end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	176.934s

[jpkrohling]

Reviewable status: complete! all files reviewed, all discussions resolved

[jpkrohling]

Thanks, @Atul9!