-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move pkg/configmap to pkg/config/ui #152
Move pkg/configmap to pkg/config/ui #152
Conversation
Signed-off-by: Atul Bhosale <atul1bhosale@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 28 28
Lines 1267 1267
=======================================
Hits 1219 1219
Misses 37 37
Partials 11 11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Atul9)
a discussion (no related file):
I believe there might be other places to change as well, as the e2e tests doesn't seem to be passing with this PR:
--- FAIL: TestJaeger/jaeger-group/my-other-jaeger (30.85s)
client.go:57: resource type RoleBinding with namespace/name (jaeger-jaeger-group-my-other-jaeger-1543913238/jaeger-operator) created
client.go:57: resource type Role with namespace/name (jaeger-jaeger-group-my-other-jaeger-1543913238/jaeger-operator) created
client.go:57: resource type ServiceAccount with namespace/name (jaeger-jaeger-group-my-other-jaeger-1543913238/jaeger-operator) created
client.go:57: resource type Deployment with namespace/name (jaeger-jaeger-group-my-other-jaeger-1543913238/jaeger-operator) created
jaeger_test.go:57: Initialized cluster resources. Namespace: jaeger-jaeger-group-my-other-jaeger-1543913238
wait_util.go:51: Deployment available (1/1)
client.go:57: resource type Jaeger with namespace/name (jaeger-jaeger-group-my-other-jaeger-1543913238/my-jaeger) created
wait_util.go:45: Waiting for full availability of my-jaeger deployment (0/1)
wait_util.go:45: Waiting for full availability of my-jaeger deployment (0/1)
wait_util.go:51: Deployment available (1/1)
client.go:57: resource type Jaeger with namespace/name (jaeger-jaeger-group-my-other-jaeger-1543913238/all-in-one-with-ui-config) created
wait_util.go:87: Ingress available
all_in_one_test.go:32: unexpected status code 503
We might be getting bitten by kubernetes-retired/contrib#1718 Re-running the tests made it pass:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
Thanks, @Atul9! |
closes #146
Signed-off-by: Atul Bhosale atul1bhosale@gmail.com