Rename controller to strategy #125
Conversation
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
|
This change is |
|
Summary of changes:
|
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 95.64% 95.99% +0.34%
==========================================
Files 27 27
Lines 1148 1148
==========================================
+ Hits 1098 1102 +4
+ Misses 38 36 -2
+ Partials 12 10 -2
Continue to review full report at Codecov.
|
|
@jpkrohling Before doing the review - don't like |
I'm not a big fan either and I did name it |
| @@ -179,7 +179,7 @@ func getDeployments(objs []runtime.Object) []*appsv1.Deployment { | |||
| return deps | |||
| } | |||
|
|
|||
| func assertHasAllObjects(t *testing.T, name string, objs []runtime.Object, deployments map[string]bool, daemonsets map[string]bool, services map[string]bool, ingresses map[string]bool, routes map[string]bool, serviceAccounts map[string]bool) { | |||
| func assertHasAllObjects(t *testing.T, name string, objs []runtime.Object, deployments map[string]bool, daemonsets map[string]bool, services map[string]bool, ingresses map[string]bool, routes map[string]bool, serviceAccounts map[string]bool, configMaps map[string]bool) { | |||
There was a problem hiding this comment.
Not necessarily for now, but could probably do with a struct to contain all of these parameters.
| assertDeploymentsAndServicesForProduction(t, name, objs, true, false, false) | ||
| } | ||
|
|
||
| func TestCreateProductionDeploymentWithUIConfigMap(t *testing.T) { |
There was a problem hiding this comment.
Sorry I missed these :)
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de