-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename controller to strategy #125
Rename controller to strategy #125
Conversation
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Summary of changes:
|
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 95.64% 95.99% +0.34%
==========================================
Files 27 27
Lines 1148 1148
==========================================
+ Hits 1098 1102 +4
+ Misses 38 36 -2
+ Partials 12 10 -2
Continue to review full report at Codecov.
|
@jpkrohling Before doing the review - don't like |
I'm not a big fan either and I did name it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - although codecov/patch has failed still.
@@ -179,7 +179,7 @@ func getDeployments(objs []runtime.Object) []*appsv1.Deployment { | |||
return deps | |||
} | |||
|
|||
func assertHasAllObjects(t *testing.T, name string, objs []runtime.Object, deployments map[string]bool, daemonsets map[string]bool, services map[string]bool, ingresses map[string]bool, routes map[string]bool, serviceAccounts map[string]bool) { | |||
func assertHasAllObjects(t *testing.T, name string, objs []runtime.Object, deployments map[string]bool, daemonsets map[string]bool, services map[string]bool, ingresses map[string]bool, routes map[string]bool, serviceAccounts map[string]bool, configMaps map[string]bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily for now, but could probably do with a struct to contain all of these parameters.
assertDeploymentsAndServicesForProduction(t, name, objs, true, false, false) | ||
} | ||
|
||
func TestCreateProductionDeploymentWithUIConfigMap(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed these :)
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de