This repository has been archived by the owner on May 18, 2020. It is now read-only.
Use recommended labels #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>
|
We had a very similar PR for the Operator: jaegertracing/jaeger-operator#172 It would be nice to be consistent here, especially regarding backwards compatibility. |
Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>
|
Thanks @jpkrohling , I've added back the original |
jpkrohling
reviewed
Feb 11, 2019
There was a problem hiding this comment.
LGTM. The build is failing due to #114, so, once that one is merged, please rebase this PR and push an update, so that Travis can run run the tests incorporating your changes.
|
Great, thanks @jpkrohling ! |
|
bump |
|
Thanks for reminding me and thanks for your contribution! |
|
My pleasure! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Not a problem per se, but using standards helps everybody in the long run.
Short description of the changes
Using recommended labels as per https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
If approved I will go on to make a similar change to the incubating helm chart.
PS Also updated some images.
TIA