Functional Components #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrenneke
changed the title
jackmellis
requested changes
Dec 13, 2018
@vue/component-compiler-utils uses it internally
jackmellis
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix made in 935c59e doesn't actually work. It's because functional components in
.vuefiles need to be compiled differently, so that the render function is functional, instead of usingthis.If a component does not have a
<script>tag, it shouldn't be treated as a functional component. Functional components should only be if you use<template functional>All of that work has already been done in @vue/component-compiler-utils, so I've switched parsing and compiling over to that library, and taken a couple more ideas from vue-loader.
This MR fixes components without
<script>tags, and adds support for functional components using<template functional>. Using @vue/component-compiler-utils may have other features/side-effects as well (however, all tests pass).